Skip to content

Retire oxigraph-worker backend#1539

Open
branarakic wants to merge 11 commits into
mainfrom
codex/remove-oxigraph-worker
Open

Retire oxigraph-worker backend#1539
branarakic wants to merge 11 commits into
mainfrom
codex/remove-oxigraph-worker

Conversation

@branarakic

Copy link
Copy Markdown
Contributor

Summary

  • remove the storage package's oxigraph-worker adapter/export/registration and delete its worker-specific tests
  • make explicit oxigraph-worker configs fail fast, while block-less daemon configs resolve to oxigraph-server with a legacy store.nq acknowledgement guard
  • update CLI setup flows, daemon fixtures, docs, devnet/smoke scripts, and benchmarks to use supported backends

Verification

  • pnpm --filter @origintrail-official/dkg-core build
  • pnpm --filter @origintrail-official/dkg-storage build
  • pnpm --filter @origintrail-official/dkg-storage exec vitest run test/storage.test.ts test/is-external-backend.test.ts
  • pnpm --filter @origintrail-official/dkg-agent... build
  • pnpm --filter @origintrail-official/dkg build
  • pnpm --filter @origintrail-official/dkg exec vitest run test/store-wizard.test.ts test/validate-store-config.test.ts test/chain-reset-wipe.test.ts test/store-health-check.test.ts test/store-identity-tag.test.ts test/oxigraph-managed.test.ts
  • pnpm --filter @origintrail-official/dkg-storage exec vitest run test/graph-set-index-store.test.ts
  • pnpm --filter @origintrail-official/dkg exec vitest run test/daemon-http-behavior-extra.test.ts test/daemon/plugin-routes-api.e2e.test.ts
  • pnpm exec tsc -p bench/tsconfig.json --noEmit

Comment thread packages/cli/src/daemon/lifecycle.ts Outdated
Comment thread packages/cli/src/store-wizard.ts Outdated
Comment thread packages/cli/src/daemon/lifecycle.ts Outdated
Comment thread bench/store-read-latency.bench.ts
@branarakic branarakic force-pushed the codex/remove-oxigraph-worker branch from 4894803 to b842ba8 Compare July 9, 2026 00:31
@branarakic

Copy link
Copy Markdown
Contributor Author

Addressed the review feedback in b842ba8:

  • Extracted daemon store default/migration/runtime views into packages/cli/src/daemon/store-runtime.ts and wired lifecycle through storeBoot / storeRuntime.
  • Added daemon startup regression coverage for legacy store.nq: aborts without DKG_ACCEPT_STORE_RESET=1, continues with effective oxigraph-server when acknowledged.
  • Replaced store-wizard parallel backend lists/branches with one typed backend policy table, including retired oxigraph-worker and oxigraph-persistent path handling/error text.
  • Collapsed the read-latency benchmark's single-backend scaffolding now that oxigraph-worker is retired.

Verification run locally:

  • pnpm --filter @origintrail-official/dkg exec vitest run test/daemon-startup-validation.test.ts test/store-wizard.test.ts
  • pnpm --filter @origintrail-official/dkg exec vitest run test/validate-store-config.test.ts test/chain-reset-wipe.test.ts test/store-health-check.test.ts test/store-identity-tag.test.ts test/oxigraph-managed.test.ts test/daemon-startup-validation.test.ts test/store-wizard.test.ts
  • pnpm --filter @origintrail-official/dkg exec tsc -p tsconfig.json --noEmit
  • pnpm exec tsc -p bench/tsconfig.json --noEmit
  • pnpm --filter @origintrail-official/dkg build
  • git diff --check

Comment thread packages/cli/src/daemon/store-runtime.ts Outdated
Comment thread packages/cli/test/daemon-startup-validation.test.ts Outdated
Comment thread packages/cli/src/publisher-runner.ts
@branarakic

Copy link
Copy Markdown
Contributor Author

Follow-up review fixes landed in a5ee42c.\n\nWhat changed:\n- added a canonical typed backend-policy table shared by wizard, validation, and command help\n- preserved operator config separately from the runtime-effective store config\n- closed the legacy store reset-ack bypass for explicit worker and wizard-rewritten server configs\n- asserted the real managed oxigraph -> sparql-http runtime handoff\n- added persistence coverage for the standalone publisher no-store fallback\n\nVerification:\n- focused store/startup/wizard/config/publisher matrix: 112 passed\n- CLI build: passed\n- CLI full suite: 2,141 passed, 12 skipped; the only failing file was the unrelated daemon-http-inflight-cap timing stress (3 assertions expecting at least one shed request). It reproduces identically on the prior PR head b842ba8: all requests finish before contention is observed.\n- publisher full suite: 1,223 passed, 6 skipped\n- agent unit suite: 239 passed\n- agent build, CLI TypeScript, bench TypeScript, and diff checks: passed\n\nAll seven review threads have been replied to and resolved.

@branarakic branarakic changed the base branch from feat/drag-v1 to main July 12, 2026 23:05
@branarakic branarakic force-pushed the codex/remove-oxigraph-worker branch from a5ee42c to d834048 Compare July 12, 2026 23:05
Comment thread packages/cli/src/daemon/routes/status.ts Outdated
Comment thread packages/cli/src/daemon/store-runtime.ts Outdated
Comment thread packages/cli/src/store-backends.ts Outdated
@branarakic branarakic force-pushed the codex/remove-oxigraph-worker branch from 5e534f8 to 53aa78d Compare July 13, 2026 00:04
Comment thread packages/cli/src/store-backends.ts Outdated
Comment thread packages/cli/src/daemon/store-runtime.ts Outdated
Comment thread packages/storage/src/triple-store.ts Outdated
Comment thread packages/storage/src/store-backends.ts Outdated
Comment thread packages/storage/src/triple-store.ts Outdated
Comment thread packages/cli/src/daemon/lifecycle.ts Outdated
Comment thread packages/storage/src/store-backends.ts Outdated
Comment thread packages/cli/src/daemon/store-runtime.ts Outdated
Comment thread packages/cli/src/store-backends.ts Outdated
Comment thread packages/storage/test/storage.test.ts
@branarakic

Copy link
Copy Markdown
Contributor Author

Mergeability handoff\n\n- Base: main at 684cd88\n- Head: 3fcbdc3\n- Review: every thread has been answered and resolved; unresolved thread count is zero.\n- Main changes: retired oxigraph-worker support and stale tests/docs removed; managed oxigraph-server startup and migration paths hardened; operator/effective/runtime store views made explicit; storage adapter metadata separated from CLI daemon policy; daemon-down publisher behavior made explicit; backend choices split by config, wizard, and flag capabilities.\n- Local verification: all 15 runtime packages built; full storage suite passed (324 passed, 25 skipped integration tests); affected CLI suite passed (87/87), including real-daemon status coverage.\n- GitHub CI: all 41 check runs completed with zero failures and zero pending (36 success, 5 skipped); both GitBook status contexts are successful.\n- GitHub reports the branch MERGEABLE. The only remaining branch-protection gate is an external human approval (REVIEW_REQUIRED).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants